[19.0][FIX] loyalty: incomplete migration#5673
Open
hbrunn wants to merge 1 commit into
Open
Conversation
OCA-git-bot
added
mod:openupgrade_scripts
hbrunn
changed the title
Member
Author
|
/ocabot migration loyalty Depends on :
|
dnplkndll
added a commit
to ledoent/OpenUpgrade
that referenced
this pull request
Jun 19, 2026
… card templates On top of OCA#5673: the standard gift_card/loyalty_card templates are reset by the non-noupdate module update, but custom loyalty.card templates referencing the removed object._get_mail_partner() helper are not, and the 19.0 data-load render aborts on the missing method before post-migration runs. Rewrite the helper back to its exact 18.0 equivalent (object.partner_id, the recipient) across every stored template field (lang/partner_to/email_to/body_html) of model loyalty.card. fix_template_lang runs first so the standard templates' lang is already NULL and untouched here.
Contributor
|
@hbrunn is this out of scope like the backfill on dates since would hit a copy only? hbrunn/OpenUpgrade@19.0-fix-crm...ledoent:OpenUpgrade:19.0-fix-loyalty-suggestion |
Member
Author
|
it's not out of scope, the replacement should however be People with custom reports will have to fix them themselves. You can propose your fix after this one is merged, which will be faster if you actually take part in the review process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previous attempt was incomplete and wrong